stream: when value is already in buffer don't emit the next one#46813
Closed
rluvaton wants to merge 6 commits intonodejs:mainfrom
Closed
stream: when value is already in buffer don't emit the next one#46813rluvaton wants to merge 6 commits intonodejs:mainfrom
rluvaton wants to merge 6 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
rluvaton
changed the title
Member
|
I don't understand what this is trying to solve. |
Member
Author
|
The bug that this PR fixes |
rluvaton
commented
Feb 24, 2023
| errorOrDestroy(stream, err, true); | ||
| } else { | ||
| process.nextTick(emitConstructNT, stream); | ||
| emitConstructNT(stream); |
Member
Author
There was a problem hiding this comment.
This fixes the issue, @ronag I see you added this code, is there a purpose for the next tick?
Member
Author
There was a problem hiding this comment.
I'm still trying to understand why it was fixed... race condition between who?
ronag
requested changes
Feb 24, 2023
Member
ronag
left a comment
ronag
left a comment
There was a problem hiding this comment.
I think #46765 (comment) is the correct fix.
Member
Author
|
Thanks @ronag. Closing my PR in favor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #46765
this is probably not the best solution, I would like to know if there is a better one.
The problem happens because when getting a second value and:
returns
false, so we write the second value withstream._write, and thenclearBufferis called which emits the restthis PR is not ready to be merged, I did not set it as draft so I would be able to run tests